Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ModelProviderMenu component and reused it in PromptsendButton and MessageBase #730

Merged
merged 11 commits into from
Nov 21, 2024

Conversation

hpatel292-seneca
Copy link
Collaborator

This is Requested from #729

@humphd humphd requested review from Amnish04 and removed request for humphd November 16, 2024 20:13
@humphd
Copy link
Collaborator

humphd commented Nov 16, 2024

Can we close #729?

Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpatel292-seneca I've left some feedback. We need to replace this Menu with our custom implementation that supports SubMenus so you don't have to use an ad-hoc approach.

src/components/Menu/ModelProviderMenu.tsx Outdated Show resolved Hide resolved
src/components/Menu/ModelProviderMenu.tsx Outdated Show resolved Hide resolved
src/components/PromptForm/PromptSendButton.tsx Outdated Show resolved Hide resolved
src/components/PromptForm/PromptSendButton.tsx Outdated Show resolved Hide resolved
src/components/PromptForm/PromptSendButton.tsx Outdated Show resolved Hide resolved
src/components/PromptForm/PromptSendButton.tsx Outdated Show resolved Hide resolved
@tarasglek
Copy link
Owner

Thanks for moving the pull req over. I agree with Amnish re reusing code more. I suspect that might fix the only bug I found..there on first load if I click retry-with and search for "3b", the menu closes itself....on subsequent uses it seems ok

Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpatel292-seneca Just wrote some implementation ideas.

src/components/Menu/ModelProviderMenu.tsx Outdated Show resolved Hide resolved
src/components/Menu/ModelProviderMenu.tsx Outdated Show resolved Hide resolved
Copy link

cloudflare-workers-and-pages bot commented Nov 19, 2024

Deploying chatcraft-org with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5a286eb
Status: ✅  Deploy successful!
Preview URL: https://eb183631.console-overthinker-dev.pages.dev
Branch Preview URL: https://issue-643-b.console-overthinker-dev.pages.dev

View logs

@tarasglek
Copy link
Owner

tarasglek commented Nov 19, 2024

Thanks for moving the pull req over. I agree with Amnish re reusing code more. I suspect that might fix the only bug I found..there on first load if I click retry-with and search for "3b", the menu closes itself....on subsequent uses it seems ok

Sweet this bug was fixed, functionality-wise current version is perfect from my perspective!

@hpatel292-seneca
Copy link
Collaborator Author

Thanks @tarasglek, I found few bugs on mobile view while working it. I will open issues for those and if you agree to make those changes, I would to work on those.

Copy link
Collaborator

@Amnish04 Amnish04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hpatel292-seneca This works well and code looks good to me. Thanks for following up!

@humphd
Copy link
Collaborator

humphd commented Nov 20, 2024

@hpatel292-seneca can you "Resolve" the issues above that are now dealt with? It's hard to follow the current state of this PR otherwise.

Let me know when this is ready to land.

@hpatel292-seneca
Copy link
Collaborator Author

Hi @humphd,

I can send a PR for the above issue if needed. However, if we merge the PR for the above issue first, this PR will likely encounter merge conflicts, as it also modifies the same file. Let me know how you'd like to proceed.

@humphd
Copy link
Collaborator

humphd commented Nov 20, 2024

I want to get this merged first then you can improve things in follow-ups. Please resolve whatever is done above, and file a new issue with the things to be fixed next, then resolve, so we can land this.

@hpatel292-seneca
Copy link
Collaborator Author

hpatel292-seneca commented Nov 20, 2024

@humphd I resolved all 'requested changes.' Sorry, I misinterpreted your message at first.

@humphd humphd merged commit 2b698ee into main Nov 21, 2024
4 checks passed
@tarasglek
Copy link
Owner

@hpatel292-seneca this is a freaking huge quality of life improvement. Awesome work!

@hpatel292-seneca
Copy link
Collaborator Author

Thanks @tarasglek

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants