-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
app+luatest: eliminate stdout buffering and stream mixing problems #394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3f319f5
to
9b5199d
Compare
ylobankov
reviewed
May 30, 2023
There is no sense to wait for the process termination or timeout. It allows to see the output as the file's content during a test execution.
Quote from luatest/runner.lua: > -c Disable capture
Parse stdout as TAP13. Write stderr to a log file to show on a test failure. Fixes #392
There is no sense to wait till process termination and accumulate all the output in the memory.
LuatestServer.find_exe() already adds this property to the class.
Follows up #119
9b5199d
to
7c10720
Compare
The ideas behind the change: * The log is sometimes from a tarantool instance, but a luatest based test may print logs from another process to stderr. Use more general term 'log' to don't confuse anyone. * Replace term 'instance' with 'test-run server' due to the same reasons. * Make zero size and no file situations more explicit. * Catch and report 'no logfile property' situation (shouldn't occur, but was semi-handled by this code previously for some reason). * Reduce code reusability for the sake of readability and to ease future modifications.
ylobankov
approved these changes
May 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The patchset attempts to eliminate unnecessary bufferization and stdout/stderr streams mixing. It should improve observability in case of a failure (#119) and stability for tests that intensively writes to stderr (#392).
-e "io.stdout:setvbuf('no')"
to tarantool command-line arguments.Fixes #119
Fixes #392
I test it on small examples like the following:
And I didn't verify it on the real world tests.
So, please, accept the patches with caution.