Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix not necessary url_escape in cookie #82

Merged
merged 7 commits into from
May 19, 2019

Conversation

norguhtar
Copy link
Contributor

http server add uri_escape to cookie set. But it not need, and broke cookie

@norguhtar
Copy link
Contributor Author

Remove and fix not need changes in last commit on PR

Шипицын Анатолий added 4 commits May 17, 2019 12:34
From RFC 6265 (4.1.1 section):
 expires-av        = "Expires=" sane-cookie-date
 sane-cookie-date  = <rfc1123-date, defined in [RFC2616], Section 3.3.1>
@ASverdlov ASverdlov merged commit 2e62cd0 into tarantool:master May 19, 2019
@norguhtar norguhtar deleted the cookie_fix branch May 19, 2019 20:32
norguhtar added a commit to get-net/http that referenced this pull request May 24, 2019
ASverdlov added a commit that referenced this pull request Aug 26, 2019
Stop url-encoding cookie path quoting cookie expire date

From RFC 6265 (4.1.1 section):
 expires-av        = "Expires=" sane-cookie-date
 sane-cookie-date  = <rfc1123-date, defined in [RFC2616], Section 3.3.1>
knazarov pushed a commit that referenced this pull request Oct 4, 2019
Stop url-encoding cookie path quoting cookie expire date

From RFC 6265 (4.1.1 section):
 expires-av        = "Expires=" sane-cookie-date
 sane-cookie-date  = <rfc1123-date, defined in [RFC2616], Section 3.3.1>
@ligurio ligurio mentioned this pull request Oct 22, 2021
ligurio pushed a commit that referenced this pull request Oct 27, 2021
Stop url-encoding cookie path quoting cookie expire date

From RFC 6265 (4.1.1 section):
 expires-av        = "Expires=" sane-cookie-date
 sane-cookie-date  = <rfc1123-date, defined in [RFC2616], Section 3.3.1>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants