Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check previous compile version and quit if current is older #230

Closed
carbontwelve opened this issue Jul 25, 2017 · 4 comments
Closed

Check previous compile version and quit if current is older #230

carbontwelve opened this issue Jul 25, 2017 · 4 comments
Labels
enhancement needs-documentation needs-tests priority-1
Milestone
1.0.11

Comments

@carbontwelve
Copy link
Member

If someone compiles a site with Tapestry 1.0.9 and then again with 1.0.8. Tapestry should ask if they wish to continue as things may well break.
@carbontwelve carbontwelve added this to the 1.0.10 milestone Aug 1, 2017
@carbontwelve
Copy link
Member Author

carbontwelve commented Nov 3, 2017 •
edited
Loading

Maybe use https://github.com/sebastianbergmann/version and https://github.com/composer/semver

@carbontwelve
Copy link
Member Author

carbontwelve commented Nov 3, 2017 •
edited
Loading

  • Have cache file store current tapestry version number
  • Have cache throw an exception if versions are out of sync
  • Have the exception get caught by the Console application so it can gracefully exit

carbontwelve added a commit that referenced this issue Nov 3, 2017
@carbontwelve
✨ added functionality for #230
0dade58
carbontwelve added a commit that referenced this issue Nov 3, 2017
@carbontwelve
✨ completed functionality for #230
791f5bf
@carbontwelve
Copy link
Member Author

Functionality has been added. Needs tests to ensure that it doesn't break with anyone's current cache file and that the exception is output to the user when run from the command line.

carbontwelve added a commit that referenced this issue Nov 23, 2017
@carbontwelve
🔀 functionality for #230 (#267)
be6f5fd 
* ✨ added functionality for #230

* ✨ completed functionality for #230

* ✨ exceptions are now caught by the base Command and output to the user regardless of whether they choose --quiet

* ✅ added unit test for checking version

* 🚨 Apply fixes from StyleCI (#261)

* 🚨 Apply fixes from StyleCI (#266)

* ✅ added test required for PR-#267
@carbontwelve
Copy link
Member Author

This is completed by PR #267

carbontwelve added a commit that referenced this issue Nov 23, 2017
@carbontwelve
🔖 1.0.11 release (#269)
5468317 
* 🔧 updating version to 1.0.10-dev

* ✅ adding unit test for #105

* 🚧 begun adding functionality for #105

* ⬆️ updating phpunit version and upgrading deps

* 🚧 more work in progress

* 🚧 more work in progress

* 🚨 Apply fixes from StyleCI (#229)

* 🐧 fixed unit test failing on linux due to case sensitive path

* 📝 boiler plate changelog for 1.0.11

* ✨ added argument to permalink template tag (#242)

* ✅ TDD for #241

* ✨ added feature for #241

* 📝 added changelog for #241

* 🚨 Apply fixes from StyleCI (#243)

* 📝 modified changelog format for #233 (#244)

* ⬆️ composer update

* 📝 adding change log for unreleased feature

* 🎨 removed erroneous line

* ✅ TDD adding test for make command (#105)

* 🚧 added make command boilerplate

* 🚧 adding help text

* ✨ modified category permalink tag to sort categories

* 🐛 fixed test broken by category sort

* ✨ added get environment helper (#249)

* 🔨 Minor refactoring of how content gets rendered

* 📝 changelog for issue #246

* ✨ added Environment extension to plates for #246

* ✅ added unit tests for #246

* 🐛 fixed unit tests broken on linux

* 🚨 Apply fixes from StyleCI (#248)

* 🚨 Apply fixes from StyleCI (#253)

* 🐛 Bugfix for #255 (#258)

* 🐛 fixed bugs relating to #255

* 🚨 Apply fixes from StyleCI (#256)

* 🎨 adding debugging information to hash table

* ✅ adding unit test for #255

* ⬆️ upgrading dependencies

* 🎨 modified Renderer interface to add a name getter

* ✨ Static asset files now have their copy flag set upon discovery, fixes #255

* 🚨 Apply fixes from StyleCI (#257)

* 🎨 removing fluff

* ⬆️ upgrading dependencies

* 🔀 Functionality for #263 (#265)

* ✨ implemented functionality for #263

* 🚨 Apply fixes from StyleCI (#264)

* 🔀 functionality for #230 (#267)

* ✨ added functionality for #230

* ✨ completed functionality for #230

* ✨ exceptions are now caught by the base Command and output to the user regardless of whether they choose --quiet

* ✅ added unit test for checking version

* 🚨 Apply fixes from StyleCI (#261)

* 🚨 Apply fixes from StyleCI (#266)

* ✅ added test required for PR-#267

* 🔖 updating version number for release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement needs-documentation needs-tests priority-1
Projects
None yet
Milestone
1.0.11
Development

No branches or pull requests
1 participant
@carbontwelve