Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanups and 1.0.0 preparation #5

Merged
merged 10 commits into from
Apr 16, 2020
Merged

cleanups and 1.0.0 preparation #5

merged 10 commits into from
Apr 16, 2020

Conversation

tanriol
Copy link
Owner

@tanriol tanriol commented Apr 15, 2020

Build on #4, but drop the vendored copy and everything specific to it.

tanriol added 7 commits April 3, 2020 03:10
The `probe` function was introduced to replace `find` in version 0.3.7.
Make the pregenerated and compile-time cases more alike.
The libftdi1 API is defined in a cross-platform way and should just work
on new platforms. This feature may still be desired for cases like
building against a newer libftdi version.
@tanriol tanriol marked this pull request as ready for review April 15, 2020 23:26
@cr1901
Copy link
Contributor

cr1901 commented Apr 15, 2020

Re: e73dd1d, I didn't know that include! would actually work (b/c are relative include! paths relative to the current source file or the compiler invocation directory?)! If it works, fine w/ me!

@tanriol
Copy link
Owner Author

tanriol commented Apr 15, 2020

It's documented to be relative to the current file. Yes, it compiles :-)

@cr1901
Copy link
Contributor

cr1901 commented Apr 15, 2020

@tanriol Ahhh, awesome. LGTM aside from the bindgen blurb (should be disabled by default, correct?)!

The option causes "clean" cross-platform bindings without layout tests
to be generated and written out in the source directory alongside the
pregenerated ones so that they can be easily compared and copied over to
update.
@tanriol
Copy link
Owner Author

tanriol commented Apr 16, 2020

By the way, I'm not doing this right now in this PR, but we seem to be missing quite a number of constants from the API.

@cr1901
Copy link
Contributor

cr1901 commented Apr 16, 2020

I swear, by the time I'm doing tweaking bindgen so that it actually emits the correct code, I could've written these bindings by hand in less time lmao. Uhhh, I'll take a look either tonight or tomorrow...

@tanriol
Copy link
Owner Author

tanriol commented Apr 16, 2020

Does not matter at the moment, I think... no one has asked for them yet :-)

These impls for foreign structs and for externally referenced structs
are likely incorrect anyway.
@tanriol tanriol merged commit df16739 into master Apr 16, 2020
@tanriol tanriol deleted the cleanups branch May 5, 2020 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants