-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanups and 1.0.0 preparation #5
Conversation
The `probe` function was introduced to replace `find` in version 0.3.7.
Make the pregenerated and compile-time cases more alike.
The libftdi1 API is defined in a cross-platform way and should just work on new platforms. This feature may still be desired for cases like building against a newer libftdi version.
Re: e73dd1d, I didn't know that |
It's documented to be relative to the current file. Yes, it compiles :-) |
@tanriol Ahhh, awesome. LGTM aside from the bindgen blurb (should be disabled by default, correct?)! |
The option causes "clean" cross-platform bindings without layout tests to be generated and written out in the source directory alongside the pregenerated ones so that they can be easily compared and copied over to update.
By the way, I'm not doing this right now in this PR, but we seem to be missing quite a number of constants from the API. |
I swear, by the time I'm doing tweaking bindgen so that it actually emits the correct code, I could've written these bindings by hand in less time lmao. Uhhh, I'll take a look either tonight or tomorrow... |
Does not matter at the moment, I think... no one has asked for them yet :-) |
These impls for foreign structs and for externally referenced structs are likely incorrect anyway.
Build on #4, but drop the vendored copy and everything specific to it.