-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Address sbp review #491
Conversation
Status of this @1xstj, can we get this wrapped up this week? Seems the errors are straightforward at first glance. |
Codecov ReportPatch coverage:
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more Additional details and impacted files@@ Coverage Diff @@
## master #491 +/- ##
==========================================
- Coverage 21.34% 21.33% -0.00%
==========================================
Files 67 67
Lines 4317 4426 +109
==========================================
+ Hits 921 944 +23
- Misses 3396 3482 +86
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Except all these try_into().unwrap()
everywhere, we shall handle these as errors and add a new Error variant to the DKGError
for example.
Opened a task so we dont forget #521 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LG!
Summary of changes
Changes introduced in this pull request:
Depends on tangle-network/webb-rs#117 / tangle-network/webb-rs#121
Reference issue to close (if applicable)
Closes #471