Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: polish SettingBinder #956

Merged
merged 1 commit into from
Apr 15, 2023
Merged

chore: polish SettingBinder #956

merged 1 commit into from
Apr 15, 2023

Conversation

tangcent
Copy link
Owner

No description provided.

@tangcent tangcent added the type: chore Routine maintenance task label Apr 15, 2023
@codecov-commenter
Copy link

codecov-commenter commented Apr 15, 2023

Codecov Report

Merging #956 (cbfccb5) into master (448e4c2) will increase coverage by 0.008%.
The diff coverage is 83.333%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Impacted file tree graph

@@               Coverage Diff               @@
##              master      #956       +/-   ##
===============================================
+ Coverage     59.494%   59.503%   +0.008%     
  Complexity      2325      2325               
===============================================
  Files            260       260               
  Lines          12223     12223               
  Branches        3023      3023               
===============================================
+ Hits            7272      7273        +1     
+ Misses          3316      3315        -1     
  Partials        1635      1635               
Flag Coverage Δ
unittests 59.503% <83.333%> (+0.008%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...om/itangcent/idea/plugin/settings/SettingBinder.kt 100.000% <ø> (ø)
...in/settings/helper/DefaultPostmanSettingsHelper.kt 58.929% <66.667%> (ø)
.../idea/plugin/settings/helper/HttpSettingsHelper.kt 86.792% <66.667%> (ø)
...n/settings/helper/RecommendConfigSettingsHelper.kt 77.049% <100.000%> (ø)
.../idea/plugin/settings/helper/YapiSettingsHelper.kt 71.304% <100.000%> (ø)
.../itangcent/plugin/adapter/MarkdownHtmlGenerator.kt 87.500% <100.000%> (+4.167%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 448e4c2...cbfccb5. Read the comment docs.

@tangcent tangcent merged commit 1e50389 into master Apr 15, 2023
@tangcent tangcent deleted the chore/setting branch April 16, 2023 01:20
This was referenced Apr 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore Routine maintenance task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants