Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [json5] remove lead blank lines #673

Merged
merged 1 commit into from
Dec 23, 2021
Merged

fix: [json5] remove lead blank lines #673

merged 1 commit into from
Dec 23, 2021

Conversation

tangcent
Copy link
Owner

No description provided.

@tangcent tangcent added the type: bug Something isn't working label Dec 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #673 (18da189) into master (ac396a2) will decrease coverage by 0.294%.
The diff coverage is 68.182%.

Impacted file tree graph

@@               Coverage Diff               @@
##              master      #673       +/-   ##
===============================================
- Coverage     58.046%   57.752%   -0.294%     
+ Complexity      2079      2077        -2     
===============================================
  Files            242       242               
  Lines          10962     11016       +54     
  Branches        2556      2565        +9     
===============================================
- Hits            6363      6362        -1     
- Misses          3383      3431       +48     
- Partials        1216      1223        +7     
Flag Coverage Δ
unittests 57.752% <68.182%> (-0.294%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n/com/itangcent/idea/plugin/json/Json5Formatter.kt 93.162% <68.182%> (-5.929%) ⬇️
...itangcent/idea/plugin/settings/XmlSettingBinder.kt 62.500% <0.000%> (-4.167%) ⬇️
.../itangcent/idea/plugin/dialog/EasyApiSettingGUI.kt 0.000% <0.000%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac396a2...18da189. Read the comment docs.

@tangcent tangcent merged commit 62b62e6 into master Dec 23, 2021
@tangcent tangcent mentioned this pull request Dec 26, 2021
@tangcent tangcent deleted the fix/json5 branch January 18, 2022 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants