Add support for initial names like JJ Abrams and JD Salinger #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates
Support two-letter names like JJ, JD, AJ, TJ. Most two-letter no-vowel words are initials and should left in uppercase.
There are some exceptions, such as Mr, Ms, Dr. These are explicitly left in mixed case.
Discussion
This PR aims to fix #16.
I ran into some trouble with
Ms SmithandLt Worfas exceptions due to those being supported post nominals; extra care may need to be added to ensure a leading space for post nominals? This may also fix "Ed". For now, I left FIXME comments in the code and tried to keep this PR limited in scope.Happy to tweak my test cases or expand on this PR more, just let me know what you need to get it across the finish line!