Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move patcher to thor command patch #284

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Conversation

ronaldtse
Copy link
Contributor

Fix #170

Copy link

codecov bot commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (a7f5fda) to head (b2d05c7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #284   +/-   ##
=======================================
  Coverage   98.15%   98.15%           
=======================================
  Files          25       25           
  Lines        1298     1298           
=======================================
  Hits         1274     1274           
  Misses         24       24           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ronaldtse
Copy link
Contributor Author

@maxirmx yes I am aware of that this is a private interface... I still think it is a good idea to keep that code in a CLI framework, and so that we only have one CLI executable, but what do you think about:

  • renaming the command to a more obscure one like tebako __internal_patch pass1
  • hiding the command behind an internal subcommand tebako __internal patch pass1

?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Convert exe/tebako-packager into Thor
1 participant