Add upgrade request/response callbacks #132
Conversation
These callbacks are invoked during the handshake just before the upgrade request is sent and just after the response is received.
TobiasBrandt-Talos
force-pushed
the
tobiasbrandt/add-upgrade-request-response-callbacks
branch
from
305bf9d to
f3682e8
Compare
| @@ -820,6 +830,10 @@ func (s *WebsocketStream) upgrade( | |||
| } | |||
| s.hb = s.hb[:0] | |||
|
|
|||
| if s.upResCb != nil { | |||
There was a problem hiding this comment.
shouldn't this be called after we assert that the handshake response is valid below? Or is there a use-case to snoop into a potentially invalid response?
There was a problem hiding this comment.
The latter. The main motivation for this is to be able to log the request/response so we can debug failed handshakes.
| // just before the upgrade request is sent. | ||
| // | ||
| // The caller must not perform any operations on the stream in the provided callback. | ||
| SetUpgradeRequestCallback(callback UpgradeRequestCallback) |
There was a problem hiding this comment.
I'm guessing this is here in order to provide the http.Request to the caller for potential modification... which for the handshake means adding more headers. If so, we already have this mechanism of adding extra headers to the handshake, see here (this is used in bullish iirc)
There was a problem hiding this comment.
It's for logging the request (at least for my use case).
These callbacks are invoked during the handshake just before the upgrade request is sent and just after the response is received.