GLBRangeRequests: Avoid duplicated full content download #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If server doesn't support range requests it responds with 200 status and full content for range requests. FileLoader raises an error if it receives 200 status for range requests. Currently the plugin invokes glTFLoader.load(url) as fallback if detecting an error while loading json chunk. The fallback load(url) can cause full range request. This commit avoid the duplicated full range content downloading by reusing the full content loaded by the first range request. Probably duplicated full range content downloading may not be a big deal because browser's disk cache works. But just in case we want to avoid it even in JavaScript level.
This was referenced Oct 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If server doesn't support range requests it responds with 200 status and full content for range requests. FileLoader raises an error if it receives 200 status for range requests.
Currently the plugin invokes glTFLoader.load(url) as fallback if detecting an error while loading json chunk. The fallback load(url) can cause full range request.
This commit avoid the duplicated full range content downloading by reusing the full content loaded by the first range request.
Probably duplicated full range content downloading may not be a big deal because browser's disk cache works. But just in case we want to avoid it even in JavaScript level.