Ensure escaped theme variables are handled correctly #16064
Merged
+62
−13
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ensures that escaped theme variables are properly handled. We do this by moving the
escape
/unescape
responsibility back into the main tailwindcss entrypoint that reads and writes from the CSS and making sure that _all internal state of theTheme
class are unescaped classes.However, due to us accidentally shipping the part where a dot in the theme variable would translate to an underscore in CSS already, this logic is going to stay as-is for now.
Here's an example test that visualizes the new changes:
Test plan
Added a unit test
Ensure this works end-to-end using the Vite playground: