Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve IE compatibility for flex-1 utility #549

Closed
scottbedard opened this issue Sep 8, 2018 · 3 comments
Closed

Improve IE compatibility for flex-1 utility #549

scottbedard opened this issue Sep 8, 2018 · 3 comments

Comments

@scottbedard
Copy link
Contributor

IE has trouble understanding our flex-1 utility, perhaps we should avoid using the flex: 1 shorthand and be more explicit. After some digging, I wound up on this stackoverflow page and am now overwriting my flex-1 class with the following...

flex: 1 1 0;

FWIW, Edge seems to handle the existing utility just fine.

@iadcode
Copy link

iadcode commented Sep 10, 2018

This sounds like Flexbug #6.

Speaking of Flexbugs however, the above flex definition you're now using might cause Flexbug #4, which you could solve by using this:

flex: 1 1 0%;

There's also luisrudge/postcss-flexbugs-fixes which fixes both #4 and #6. You could just wack that into your PostCSS config after Tailwind.

@scottbedard
Copy link
Contributor Author

Ah, thank you for the info, I always forget about that awesome repo. Would there be any downside to having our flex-1 utility written this way out of the box? It seems like a bit of a gotcha to use the shorthand, and then leaving it up to the user to apply this fix. If the maintainers oppose this change though, no worries, go ahead and close this issue.

@adamwathan
Copy link
Member

adamwathan commented Sep 10, 2018 via email

scottbedard added a commit to scottbedard/tailwindcss that referenced this issue Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants