Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prose elements legacy mode. Fixes #258 #259

Merged
merged 3 commits into from
Mar 25, 2022
Merged

Fix prose elements legacy mode. Fixes #258 #259

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
01b7596
Fix prose elements `legacy` mode. Fixes #258
Folyd Mar 22, 2022
21e104d
Add test
thecrypticace Mar 25, 2022
b3a74a7
Fix legacy mode custom element selectors
thecrypticace Mar 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ module.exports = plugin.withOptions(
['video'],
['hr'],
]) {
addVariant(`${className}-${name}`, `& :is(${inWhere(selector, options)})`)
addVariant(`${className}-${name}`, target === 'legacy' ? `& ${selector}` : `& :is(${inWhere(selector, options)})`)
}

addComponents(
Expand Down
5 changes: 4 additions & 1 deletion src/index.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -335,7 +335,7 @@ test('modifiers', async () => {
test('legacy target', async () => {
let config = {
plugins: [typographyPlugin({ target: 'legacy' })],
content: [{ raw: html`<div class="prose"></div>` }],
content: [{ raw: html`<div class="prose prose-h1:text-center"></div>` }],
theme: {
typography: {
DEFAULT: {
Expand Down Expand Up @@ -423,6 +423,9 @@ test('legacy target', async () => {
.prose code::after {
content: '&#96;';
}
.prose-h1\:text-center h1 {
text-align: center;
}
`
)
})
Expand Down