Add connector fields to ACL #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DentonGentry
reviewed
Dec 6, 2023
| @@ -373,8 +373,15 @@ type ( | |||
| } | |||
|
|
|||
| NodeAttrGrant struct { | |||
| Target []string `json:"target,omitempty" hujson:"Target,omitempty"` | |||
| Attr []string `json:"attr,omitempty" hujson:"Attr,omitempty"` | |||
| Target []string `json:"target,omitempty" hujson:"Target,omitempty"` | |||
There was a problem hiding this comment.
I am mindful that this is a public PR. I believe there is other documentation which should be updated before we might proceed to implement this in the go-client.
Personally, the alternative you mentioned in Slack seems preferable: preserve the HuJSON.
knyar
approved these changes
Dec 8, 2023
|
We need to followup on the other options, like allowing arbitrary HuJSON. |
I have described a high level plan in the existing issue we had for this, tailscale/terraform-provider-tailscale#227 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.