Allow deletion of unowned links #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It should be possible to delete links owned by non-existing users (tagged-devices or deleted) in the same ways as it's possible to edit these links. Signed-off-by: Marco Hofstetter <[email protected]>
Even in dev mode, the user `tagged-devices` should not be reported as existing user. This allows editing & deleting links owned by `taggged-devices` in dev mode. Signed-off-by: Marco Hofstetter <[email protected]>
willnorris
approved these changes
Jun 22, 2023
There was a problem hiding this comment.
You technically can handle this by first updating the link, which makes you the owner, and then deleting it. But that's not at all intuitive, and changing the UI to make that clearer isn't really any better than just allowing direct deletion. Thanks for the patch.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First of all, thanks for golink!
Description
It should be possible to delete links owned by non-existing users (tagged-devices or deleted) in the same ways as it's possible to edit these links.
Related PRs