add tests for serve methods #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willnorris
force-pushed
the
will/serve-tests
branch
from
a41c8d5 to
a9124b7
Compare
shayne
approved these changes
May 1, 2023
Comment on lines
+50
to
+56
| { | ||
| name: "user link", | ||
| link: "/me", | ||
| wantStatus: http.StatusFound, | ||
| wantLink: "/who/[email protected]", | ||
| }, |
There was a problem hiding this comment.
Does it make sense to add any negative tests here?
| @@ -85,8 +235,8 @@ func TestExpandLink(t *testing.T) { | |||
| for _, tt := range tests { | |||
| t.Run(tt.name, func(t *testing.T) { | |||
| got, err := expandLink(tt.long, expandEnv{Now: tt.now, Path: tt.remainder, User: tt.user}) | |||
| if err != nil { | |||
| t.Fatalf("expandLink(%q): %v", tt.long, err) | |||
| if (err != nil) != tt.wantErr { | |||
There was a problem hiding this comment.
I know... I'ver never found a way to test like this that I like. I've sometimes broken it apart into two different checks for whether an error is expected. 🤷🏻
Also check error returned from tmpl.Execute. Refactor currentUser to make the logic a little simpler, and make it a package var for easier testing. Signed-off-by: Will Norris <[email protected]>
willnorris
force-pushed
the
will/serve-tests
branch
from
a9124b7 to
aeae9f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also check error returned from tmpl.Execute. Refactor currentUser to make the logic a little simpler, and make it a package var for easier testing.
This doesn't make any behavioral changes (aside from checking the tmpl.Execute error). Instead, it's focused on making the next pass at #72 much simpler to review.