golink: check for CertDomains before enabling HTTPS #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
patrickod
force-pushed
the
patrickod/ensure-certdomains-listen-tls
branch
from
90dc700 to
af9ca1f
Compare
creachadair
approved these changes
Dec 20, 2023
awly
approved these changes
Dec 20, 2023
Fixes #102 Ensure that we have CertDomains for the HTTPS listener before asking tsnet to create one. Signed-off-by: Patrick O'Doherty <[email protected]>
patrickod
force-pushed
the
patrickod/ensure-certdomains-listen-tls
branch
from
af9ca1f to
5be3577
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
Ensure that we have CertDomains for the HTTPS listener before asking
tsnet to create one.