Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore trailing dot #148

Closed
bradfitz opened this issue Oct 31, 2024 · 2 comments · Fixed by #159
Closed

Ignore trailing dot #148

bradfitz opened this issue Oct 31, 2024 · 2 comments · Fixed by #159

Comments

@bradfitz
Copy link
Member

I went to http://go/foo. and got a 404. But http://go/foo works.

On 404, try to trim the trailing dot and try that? For people copy/pasting links with a trailing period in a sentence.

/cc @willnorris
@bradfitz bradfitz changed the title Ignore tailing dot Ignore trailing dot Oct 31, 2024
@willnorris
Copy link
Member

willnorris commented Oct 31, 2024 •
edited
Loading

Probably all punctuation characters. I can imagine ) and , being pretty common

@parkr
Copy link

parkr commented Nov 1, 2024

It's probably handled by extracting the path only but header links like go/foo#my-heading-(parenthetical) would break if punctuation is removed from the full URL without first extracting the path.

willnorris added a commit that referenced this issue Jan 10, 2025
@willnorris
golink: strip trailing punctuation when resolving links
197d030 
It's not uncommon for auto-linkers or simple copy/paste errors to
accidentally include trailing punctuation in a golink. When resolving
links, if the initial link was not found, then try again with common
punctuation (that is invalid in link names anyway) removed.

Fixes #148

Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d
Signed-off-by: Will Norris <[email protected]>
@willnorris willnorris mentioned this issue Jan 10, 2025
Merged
willnorris added a commit that referenced this issue Jan 10, 2025
@willnorris
golink: strip trailing punctuation when resolving links
c21529a 
It's not uncommon for auto-linkers or simple copy/paste errors to
accidentally include trailing punctuation in a golink. When resolving
links, if the initial link was not found, then try again with common
punctuation (that is invalid in link names anyway) removed.

Fixes #148

Change-Id: Ia101a4a3005adb9118051b3416f5a64a4a45987d
Signed-off-by: Will Norris <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

golink: strip trailing punctuation when resolving links tailscale/golink
3 participants
@willnorris @bradfitz @parkr