-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): add SP1 verification support #17861
Conversation
feat(protocol): add SP1 verification support
🚨 Report Summary
For more details view the full report in OpenZeppelin Code Inspector |
@adaki2004 I think for the testnet, if we are not interacting with Sp1 contracts directly you have two ways of doing this:
Option 2 is more compatible with their setting on mainnet, option 1 is more convenient. |
Also if we want to integrate blob verification altogether see taikoxyz/raiko#292 (comment) |
I think option 1 is more close what setup we will have anyways on mainnet (since we wont be responsible for veritication + deployment anyways if not mistaken) bc. why not interacting with those stateless contracts ? These are just readonly calls. I was referring “tests” in unit test context for coverage. |
Will add deployment script + unit test Tuesday (plz dont merge till). |
This PR is aiming to integrate SP1's on-chain verifier (gateway).
Functional wise it is identical to this PR/branch: #17215 the key difference is, that SP1 now is managing the verifier deployment themselves, we just need to call into their contracts. So no need to incorporate the veriying logic into our own contracts.
Veriifer deployments: https://github.com/succinctlabs/sp1-contracts/tree/main/contracts/deployments
If accepted, i'll do a mock
VerifierGateway
contract for unit tests.