Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): add preconfirmation support [helder] #17654
feat(protocol): add preconfirmation support [helder] #17654
Changes from 36 commits
e69e360
f27e0b7
ee84153
d59db31
fac9ba8
6ef1726
de08795
b5036c3
3e0c74c
015ed34
23351f8
d021b0d
9e97bbf
507149b
4bbe16e
c29759f
a68a163
d9fbe44
0986e22
3628ae7
ed709d7
999e5d4
0a89fa0
6a0f394
f4e602a
63ba193
2052946
967f7ee
5962ba9
157cd13
7451a5a
c00bfb5
8439b00
d1ecef2
4699f96
14f5b94
0b2a987
c4fe319
73048c2
4205b96
c0f3b38
0e03c3c
b38bd37
1b6fd86
a383b19
1d1c41f
284ef1a
6579417
915f888
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tend to think, it might be better like this below if we wanna support
calldata
efficiently.So currently protocol can handle both, but with the above change, we would have to create empty
_txLists
-matched to the length of_params
, even if we use blob OR some empty if we use blob + calldata both, separately, paralel with one L1 TXN.I dont think it is practical to use different data avail. layer for multiple L2 blocks but one L1 TXN. (Maybe i'm wrong in here, and in this case inefficiency is i guess negligible).