Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nfts): add snaefell-nft smart contracts #17221

Merged
merged 24 commits into from
May 21, 2024
Merged

feat(nfts): add snaefell-nft smart contracts #17221

merged 24 commits into from
May 21, 2024

Conversation

bearni95
Copy link
Contributor

@bearni95 bearni95 commented May 16, 2024 •
edited
Loading

  • Adapt taikoon package into alpha-nft to deploy the Alpha Testnet NFT
  • Replace source images with corresponding NFT
  • Update whitelist
  • Automate IPFS/4everland posting process
  • Deployment structure
  • CI Action
  • Move onto the nfts package

@bearni95 bearni95 changed the title Alpha testnet nft feat(alpha-nft): smart contracts May 16, 2024
@bearni95 bearni95 marked this pull request as draft May 16, 2024 21:07
@openzeppelin-code OpenZeppelin Code
Copy link

openzeppelin-code bot commented May 16, 2024 •
edited
Loading

feat(nfts): add snaefell-nft smart contracts

Generated at commit: 59f645b081b2e18861a619c93088f41b6ad32020

🚨 Report Summary

Severity Level Results
Contracts Critical
High
Medium
Low
Note
Total		 2
2
0
8
42
54
Dependencies Critical
High
Medium
Low
Note
Total		 0
0
0
0
0
0

For more details view the full report in OpenZeppelin Code Inspector

@bearni95 bearni95 mentioned this pull request May 16, 2024
Merged
5 tasks
@bearni95 bearni95 changed the title feat(alpha-nft): smart contracts feat(snaefell-nft): smart contracts May 17, 2024
@bearni95 bearni95 marked this pull request as ready for review May 17, 2024 13:32
@dantaik
Copy link
Contributor

dantaik commented May 20, 2024

I think we should put all NFT contracts in taikoon, use it as an umbrella project for NFTs please.

@dantaik dantaik changed the title feat(snaefell-nft): smart contracts feat(taikoon): add snaefell-nft smart contracts May 20, 2024
@bearni95 bearni95 changed the title feat(taikoon): add snaefell-nft smart contracts feat(nfts): add snaefell-nft smart contracts May 20, 2024
@bearni95 bearni95 requested a review from dantaik May 20, 2024 12:00
@bearni95 bearni95 requested a review from dionysuzx May 20, 2024 16:48
@dantaik dantaik added this pull request to the merge queue May 21, 2024
Merged via the queue into main with commit ef3d7d5 May 21, 2024
4 checks passed
@dantaik dantaik deleted the alpha-testnet-nft branch May 21, 2024 17:26
@taiko-kitty taiko-kitty mentioned this pull request May 21, 2024
Closed
@taiko-kitty taiko-kitty mentioned this pull request Jun 13, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dionysuzx dionysuzx dionysuzx approved these changes

@dantaik dantaik dantaik approved these changes

@2manslkh 2manslkh Awaiting requested review from 2manslkh

@adaki2004 adaki2004 Awaiting requested review from adaki2004

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bearni95 @dantaik @dionysuzx