fix(protocol): fix bridge quota processing and make processMessage return data
#17027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix(protocol): fix bridge quota processing and make
|
| Severity Level | Results | |
|---|---|---|
| Contracts | Critical High Medium Low Note Total |
2 2 0 5 41 50 |
| Dependencies | Critical High Medium Low Note Total |
0 0 0 0 0 0 |
For more details view the full report in OpenZeppelin Code Inspector
dantaik
changed the title
Brechtpd
approved these changes
May 8, 2024
…d reason (#17043) Co-authored-by: dantaik <[email protected]>
dantaik
changed the title
processMessage
dantaik
changed the title
processMessageprocessMessage return data
Brechtpd
approved these changes
May 8, 2024
davidtaikocha
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BEGIN_COMMIT_OVERRIDE
feat(protocol): make bridge processMessage return message's status and reason
fix(protocol): fix bridge quota processing in processMessage
END_COMMIT_OVERRIDE
Regarding
fix bridge quota processing in processMessageBefore this PR
If the bridge is out of ETH quota, the
processMessagetransaction will fail without marking the message as "retryable", which will keep the message unprocessable and ether locked on the source chain, because this message has to wait for enough quota to be available and cannot be recalled to unlock the funds on the source chain.After this PR
If there is not enough quota, the message is marked as retrievable, however, no fees are paid to the bridge processor ,otherwise, a very high
message.feecan be used to paymessage.destOwnerto get around of the ETH quota verification. The message can be retried or recalled to unlock funds.