feat(protocol): restrict max gas paying prover #15200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
davidtaikocha
approved these changes
Nov 13, 2023
Brechtpd
approved these changes
Nov 13, 2023
Comment on lines
+31
to
+33
| // Max gas paying the prover. This should be large enough to prevent the | ||
| // worst cases, usually block proposer shall be aware the risks and only | ||
| // choose provers that cannot consume too much gas when receiving Ether. |
There was a problem hiding this comment.
Easy for provers to give the proposer an address that is an EOA and then deploy a smart contract to that address that consumes a lot of gas!
There was a problem hiding this comment.
Yes, but provers are most likely entities that win their businesses over time by behaving well, some metrics are important for proposer when to consider which provers to use.
There was a problem hiding this comment.
Shouldn't they just pick the prover that offers the lowest fee? Anything that is more trust based seems like a downside for the system to work as well and efficient as possible. Any trust based system would also be more centralizing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.