-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(protocol): lower top tier proof cost #14922
feat(protocol): lower top tier proof cost #14922
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
Codecov Report
@@ Coverage Diff @@
## contestable-zkrollup #14922 +/- ##
========================================================
+ Coverage 38.66% 38.70% +0.03%
========================================================
Files 114 114
Lines 5434 5434
Branches 113 113
========================================================
+ Hits 2101 2103 +2
+ Misses 3197 3195 -2
Partials 136 136
*This pull request uses carry forward flags. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Logic wise LGTM, but i have one other concern. This introduces extra variable + some logic which ( at first glance seems not significant but) results in +10% on average and +27% in median |
@adaki2004 in our test, we used If I change this provider to always return 0 for maxBlockToVerify: As you can see the gas changes is fairly small. |
The goal is to make the muti-sig based guardian prover's cost to be as small as possible. We now config the number of blocks to verify after each proveBlock tranaction inside the tier config, instead of using a global config for all tiers.