Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(protocol): fix issue in slash amount calc #14272

Merged
merged 3 commits into from
Jul 25, 2023
Merged

Conversation

dantaik
Copy link
Contributor

@dantaik dantaik commented Jul 25, 2023

davidtaikocha
davidtaikocha previously approved these changes Jul 25, 2023
@adaki2004
Copy link
Contributor

Copying here what i wrote to Discord - about the root cause and possible fix:

We are having a discussion with ZK Pool.
They raised the topic - and this is why we think we see lots of slashes :
They need to stake with MAX_CAPACITY_LOWER_BOUND 128. Which means they have the capacity to prove 128 blcosk in parallel. They say:
128 is the mininum capacity, but in reality it is very unlikely we run 128 provers 🙂
calculated the current block speed, with a few clusters from David  running on parallel, I thought 20 + 20 provers should be enough  for the amount we staked.
Would it make sense to reduce this 128 to 20 for example.. ? I know it might result in 'free market proving' (to not stakers but anyonw) but less slashing.

adaki2004
adaki2004 previously approved these changes Jul 25, 2023
@adaki2004
Copy link
Contributor

(This min. amount removal helps with reducing/slowing down to 0, but that 128 min required capacity would hurt provers who does not have that parallel capacity)

@dantaik
Copy link
Contributor Author

dantaik commented Jul 25, 2023

Copying here what i wrote to Discord - about the root cause and possible fix:

We are having a discussion with ZK Pool.
They raised the topic - and this is why we think we see lots of slashes :
They need to stake with MAX_CAPACITY_LOWER_BOUND 128. Which means they have the capacity to prove 128 blcosk in parallel. They say:
128 is the mininum capacity, but in reality it is very unlikely we run 128 provers 🙂
calculated the current block speed, with a few clusters from David  running on parallel, I thought 20 + 20 provers should be enough  for the amount we staked.
Would it make sense to reduce this 128 to 20 for example.. ? I know it might result in 'free market proving' (to not stakers but anyonw) but less slashing.

I changed it to 32.

@davidtaikocha davidtaikocha merged commit 8cd932c into alpha-4 Jul 25, 2023
@davidtaikocha davidtaikocha deleted the slash_calc branch July 25, 2023 10:29
davidtaikocha added a commit that referenced this pull request Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the L3's economic, the slash amount is too big compared with proof reward
4 participants