Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(protocol): decouple proof(s) verification from core protocol #14221

Merged
merged 13 commits into from
Jul 29, 2023

Conversation

adaki2004
Copy link
Contributor

@adaki2004 adaki2004 commented Jul 20, 2023

This PR separates the proof verification logic.
SGX and other support can come late, and core protocol only sees bytes, no verifierId.

@dantaik
Copy link
Contributor

dantaik commented Jul 26, 2023

For the core protocol, the proof shall be just a byte array, nothing else. Then the IProofVerifier contract should look like:

function verifyBlockProof(uint blockId, bytes calldata blockProof) external;

Later we can upgrade the implementation of IProofVerifier and use blockId to perform different verification tasks.

@adaki2004

This comment was marked as resolved.

@adaki2004

This comment was marked as resolved.

@adaki2004 adaki2004 marked this pull request as ready for review July 27, 2023 08:50
@dantaik

This comment was marked as resolved.

@dantaik dantaik changed the title feat(protocol): Proof verification separation feat(protocol): decouple proof(s) verification from core protocol Jul 28, 2023
@dantaik dantaik added this pull request to the merge queue Jul 29, 2023
Merged via the queue into alpha-4 with commit 4b23d14 Jul 29, 2023
@dantaik dantaik deleted the alpha-4-separate-proof-verification branch July 29, 2023 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants