refactor(bridge-ui): storage services as modules #13598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #13598 +/- ##
==========================================
- Coverage 39.47% 37.28% -2.20%
==========================================
Files 135 128 -7
Lines 4043 3841 -202
Branches 506 506
==========================================
- Hits 1596 1432 -164
+ Misses 2343 2317 -26
+ Partials 104 92 -12
*This pull request uses carry forward flags. Click here to find out more.
... and 7 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
jscriptcoder
changed the title
|
Ready for review? |
shadab-taiko
approved these changes
Apr 23, 2023
cyberhorsey
approved these changes
Apr 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage and Token services have been turned into modules. There is no need to add them into stores nor initialize them in the App.svelte component. As soon as they're imported, they're instantiated.
What are we gaining here?, cleaner code and less initialization in the App.svelte. Unnecessary use of svelte stores.
TODO: we can do the same with the RelayerAPI service