This repository has been archived by the owner on May 11, 2024. It is now read-only.
feat: update some logic and add more tests based on #216 #228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
reviewed
May 16, 2023
|
|
||
| stateVars, err := s.rpc.GetProtocolStateVariables(nil) | ||
| if err != nil { | ||
| return fmt.Errorf("failed to get state variables: %w", err) | ||
| } | ||
|
|
||
| for { | ||
| if blockId.Cmp(big.NewInt(0)) == 0 { | ||
| lastKnownGoodBlockId = new(big.Int).SetUint64(0) | ||
| if blockId == nil && blockId.Cmp(common.Big0) == 0 { |
There was a problem hiding this comment.
blockId cant be both nil, and compared to 0? it should be || perhaps?
There was a problem hiding this comment.
changed to init blockID with current L2 head, and also changed && to ||
Codecov Report
@@ Coverage Diff @@
## handle_reorg #228 +/- ##
================================================
+ Coverage 50.67% 54.43% +3.76%
================================================
Files 36 36
Lines 3576 3525 -51
================================================
+ Hits 1812 1919 +107
+ Misses 1525 1353 -172
- Partials 239 253 +14
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
cyberhorsey
approved these changes
May 16, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.