This repository has been archived by the owner on May 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 332
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cyberhorsey
changed the title
fix(block_batch_iterator): Handle reorg
fix(driver): Handle reorg
May 10, 2023
Codecov Report
@@ Coverage Diff @@
## main #216 +/- ##
==========================================
- Coverage 52.85% 50.67% -2.19%
==========================================
Files 36 36
Lines 3415 3576 +161
==========================================
+ Hits 1805 1812 +7
- Misses 1372 1525 +153
- Partials 238 239 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
Co-authored-by: David <[email protected]>
davidtaikocha
added a commit
that referenced
this pull request
May 16, 2023
davidtaikocha
approved these changes
May 16, 2023
davidtaikocha
approved these changes
May 16, 2023
vhjiang
pushed a commit
to taikoverse/taiko-degen-client
that referenced
this pull request
Jul 1, 2023
Co-authored-by: David <[email protected]> Co-authored-by: Roger <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to handle reorg when an event is removed, previously we were just skipped, but instead we should rewind the chain.
This is very hard to test in the code without generating some mocks and refactoring how our tests work for this, but I think this is at least closer to a solution. Unsure if the spot at where I am handlign the reorg makes sense.
Closes #201 (hopefully ;))