-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to compress binaries with UPX #90
Open
mondeja
wants to merge
17
commits into
taiki-e:main
Choose a base branch
from
mondeja:upx
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
c7c5a13
Add test to CI
mondeja 5261d32
Merge branch 'main' into upx
taiki-e 017d514
Merge branch 'main' into upx
taiki-e ab004fd
Run on all targets
mondeja 680329b
Revert change
mondeja b575349
macOS
mondeja b32cccf
Check choco existence
mondeja c8bbacb
Check input
mondeja 93b0e38
Fix error
mondeja 07263ca
Fix
mondeja 0b48564
Fix lint
mondeja 6968098
Try `aarch64-unknown-linux-gnu` with cargo
mondeja 4aba213
Try `x86_64-pc-windows-gnu`
mondeja e1759a2
Debug
mondeja 7db8782
Debug
mondeja b34daee
Revert
mondeja 431c928
Merge branch 'main' into upx
mondeja File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(It seems that aarch64 is supported? https://github.com/upx/upx/blob/d00ba4b4656837c08841bd8f9599fda87bb7c7d2/src/p_lx_elf.h#L533)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/
See https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/job/34547228299?pr=90#step:6:296
win64/arm64
is not yet supportedThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems to work with aarch64 linux-gnu + build-tool=cargo.
https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/job/34547228655?pr=90
This doesn't seem to describe why x86_64 windows is skipped.
https://github.com/taiki-e/upload-rust-binary-action/actions/runs/12377523218/job/34547233333?pr=90
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
The output of the
file
command is the same when the exe is compressed with UPX or not:See this run (compressing) and this run (not compressing). I don't know how to test it.