Enable outline-atomics by default and provide cfg to disable it #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
added
O-x86
taiki-e
force-pushed
the
no-outline-atomics
branch
3 times, most recently
from
6ab6363 to
44f5d48
Compare
taiki-e
force-pushed
the
no-outline-atomics
branch
2 times, most recently
from
8bc7d54 to
f604799
Compare
|
The use of getauxval in aarch64-linux-musl has caused problems in the past, but as of rust 1.61 that we use outline-atomics in aarch64, it has already been fixed and should not cause similar problems (rust-lang/rust@9a04ae4). EDIT: The implementation of std_detect uses dlsym by default, so it is not affected anyway. bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 25, 2022
57: Enable outline-atomics by default and provide cfg to disable it r=taiki-e a=taiki-e This enables `outline-atomics` feature by default and provides `portable_atomic_no_outline_atomics` cfg to disable it. (outline-atomics enables several optimizations on x86_64 and aarch64. See [this list](#10 (comment)) for details.) It has previously been pointed out that due to the nature of the cargo feature, controlling this based on the cargo feature does not work well. Since this release, `outline-atomics` feature has been no-op, and outline-atomics is enabled by default. Note: outline-atomics in portable-atomics is currently for 128-bit atomics. outline-atomics for atomics with other sizes is controlled by LLVM's `outline-atomics` target feature. Closes #25 Co-authored-by: Taiki Endo <[email protected]>
|
bors r- |
|
Canceled. |
taiki-e
force-pushed
the
no-outline-atomics
branch
from
f604799 to
de9be7d
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 25, 2022
57: Enable outline-atomics by default and provide cfg to disable it r=taiki-e a=taiki-e This enables `outline-atomics` feature by default and provides `portable_atomic_no_outline_atomics` cfg to disable it. (outline-atomics enables several optimizations on x86_64 and aarch64. See [this list](#10 (comment)) for details.) It has previously been pointed out that due to the nature of the cargo feature, controlling this based on the cargo feature does not work well. Since this release, `outline-atomics` feature has been no-op, and outline-atomics is enabled by default. Note: outline-atomics in portable-atomics is currently for 128-bit atomics. outline-atomics for atomics with other sizes is controlled by LLVM's `outline-atomics` target feature. Closes #25 Co-authored-by: Taiki Endo <[email protected]>
taiki-e
force-pushed
the
no-outline-atomics
branch
from
de9be7d to
8946599
Compare
|
Canceled. |
|
bors r+ |
taiki-e
added
O-aarch64
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables
outline-atomicsfeature by default and providesportable_atomic_no_outline_atomicscfg to disable it.(outline-atomics enables several optimizations on x86_64 and aarch64. See this list for details.)
It has previously been pointed out that due to the nature of the cargo feature, controlling this based on the cargo feature does not work well. Since this release,
outline-atomicsfeature has been no-op, and outline-atomics is enabled by default.Note: outline-atomics in portable-atomics is currently for 128-bit atomics. outline-atomics for atomics with other sizes is controlled by LLVM's
outline-atomicstarget feature.Closes #25