Add fetch_neg/neg/fetch_not/not #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiki-e
force-pushed
the
more-ops
branch
2 times, most recently
from
da034b0 to
ef88e1c
Compare
taiki-e
force-pushed
the
more-ops
branch
3 times, most recently
from
db7db4e to
0c4a2d9
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Dec 18, 2022
54: Add fetch_neg/neg/fetch_not/not r=taiki-e a=taiki-e Part of #48 - Add `AtomicI*::{fetch_neg,neg}` and `AtomicF*::fetch_neg` methods. `AtomicI*::neg` are equivalent to the corresponding `fetch_*` methods, but do not return the previous value. They are intended for optimization on platforms that have atomic instructions for the corresponding operation, such as x86's `lock neg`. Currently, optimizations by these methods (`neg`) are only guaranteed for x86. - Add `Atomic{I,U}*::{fetch_not,not}` methods. `Atomic{I,U}*::not` are equivalent to the corresponding `fetch_*` methods, but do not return the previous value. They are intended for optimization on platforms that have atomic instructions for the corresponding operation, such as x86's `lock not`, MSP430's `inv`. Currently, optimizations by these methods (`not`) are only guaranteed for x86 and MSP430. (Note: `AtomicBool` already has `fetch_not` and `not` methods.) Co-authored-by: Taiki Endo <[email protected]>
Note: `AtomicBool` already has `fetch_not` and `not` methods.
|
Canceled. |
|
bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #48
Add
AtomicI*::{fetch_neg,neg}andAtomicF*::fetch_negmethods.AtomicI*::negare equivalent to the correspondingfetch_*methods, but do not return the previous value. They are intended for optimization on platforms that have atomic instructions for the corresponding operation, such as x86'slock neg.Currently, optimizations by these methods (
neg) are only guaranteed for x86.Add
Atomic{I,U}*::{fetch_not,not}methods.Atomic{I,U}*::notare equivalent to the correspondingfetch_*methods, but do not return the previous value. They are intended for optimization on platforms that have atomic instructions for the corresponding operation, such as x86'slock not, MSP430'sinv.Currently, optimizations by these methods (
not) are only guaranteed for x86 and MSP430.(Note:
AtomicBoolalready hasfetch_notandnotmethods.)