Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dependency on syn & proc-macro2 #35

Merged
merged 1 commit into from
Jun 23, 2021
Merged

Remove dependency on syn & proc-macro2 #35

merged 1 commit into from
Jun 23, 2021

Conversation

taiki-e
Copy link
Owner

@taiki-e taiki-e commented Jun 23, 2021

Closes #28

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 23, 2021

0.2.7 (latest release):

0 2 7

current main branch (0979861):

main

this PR (fb08a8f):

this

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 23, 2021

It is interesting to this patch has hardly increased the compile time compared to the latest release.

Normally, such a change will increase the overall compile time for the dependency graph, even if the compile time per crate is reduced, because it is usually done by copying the upstream code. (that's a kind of Prisoner's dilemma...)

@taiki-e
Copy link
Owner Author

taiki-e commented Jun 23, 2021

bors r+

@bors
Copy link
Contributor

bors bot commented Jun 23, 2021

Build succeeded:

@bors bors bot merged commit 2218c24 into main Jun 23, 2021
@bors bors bot deleted the taiki-e/dev branch June 23, 2021 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove dependency on syn & quote
1 participant