Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] update vulkan links #8624

Closed
wants to merge 4 commits into from
Closed

Conversation

johnnynunez
Copy link

No description provided.

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025

CLA assistant check
All committers have signed the CLA.

@junwha
Copy link

junwha commented Jan 18, 2025

Hi, I'm encountering the same problem here.

In addition to your patch, I think we should add xz support with "-xJf" flag
at https://github.com/taichi-dev/taichi/blob/master/.github/workflows/scripts/ti_build/dep.py#L153

sed -i '/elif name.endswith(".tar.gz") or name.endswith(".tgz"):/,/\ \ \ \ \ \ \ \ tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")/c \
    elif name.endswith(".tar.gz") or name.endswith(".tgz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")\
    elif name.endswith(".tar.xz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xJf", local_cached, "-C", outdir, f"--strip-components={strip}")' .github/workflows/scripts/ti_build/dep.py

@johnnynunez johnnynunez changed the title update vulkan links [build] update vulkan links Jan 18, 2025
@johnnynunez
Copy link
Author

Hi, I'm encountering the same problem here.

In addition to your patch, I think we should add xz support with "-xJf" flag at https://github.com/taichi-dev/taichi/blob/master/.github/workflows/scripts/ti_build/dep.py#L153

sed -i '/elif name.endswith(".tar.gz") or name.endswith(".tgz"):/,/\ \ \ \ \ \ \ \ tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")/c \
    elif name.endswith(".tar.gz") or name.endswith(".tgz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")\
    elif name.endswith(".tar.xz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xJf", local_cached, "-C", outdir, f"--strip-components={strip}")' .github/workflows/scripts/ti_build/dep.py

good catch! Done

@johnnynunez
Copy link
Author

Hi, I'm encountering the same problem here.

In addition to your patch, I think we should add xz support with "-xJf" flag at https://github.com/taichi-dev/taichi/blob/master/.github/workflows/scripts/ti_build/dep.py#L153

sed -i '/elif name.endswith(".tar.gz") or name.endswith(".tgz"):/,/\ \ \ \ \ \ \ \ tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")/c \
    elif name.endswith(".tar.gz") or name.endswith(".tgz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xzf", local_cached, "-C", outdir, f"--strip-components={strip}")\
    elif name.endswith(".tar.xz"):\
        outdir.mkdir(parents=True, exist_ok=True)\
        tar("-xJf", local_cached, "-C", outdir, f"--strip-components={strip}")' .github/workflows/scripts/ti_build/dep.py

I get vulkan arm sdk builds https://github.com/johnnynunez/vulkan-sdk-arm

@johnnynunez johnnynunez closed this by deleting the head repository Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants