Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] Fix missing .so in manylinux2014 environment #8404

Merged
merged 1 commit into from
Nov 6, 2023
Merged

[aot] Fix missing .so in manylinux2014 environment #8404

merged 1 commit into from
Nov 6, 2023

Conversation

Routhleck
Copy link
Contributor

@Routhleck Routhleck commented Nov 4, 2023

Issue: # In manylinux2014 environments, cmake can't find libtaichi_c_api.so. since the path in manylinux2014 is wrong.

Brief Summary

🤖 Generated by Copilot at e75061d

Improve the portability of the CMake configuration for the taichi C API. Use a variable to handle different library directory names on Linux.

Walkthrough

🤖 Generated by Copilot at e75061d

  • Add a conditional check to find the shared library file for the taichi C API in either lib or lib64 directory (link)
  • Use the TAICHI_SO_LOCATION variable to set the imported location and the check file list for the taichi_c_api target (link)

Copy link

netlify bot commented Nov 4, 2023

Deploy Preview for docsite-preview canceled.

Name Link
🔨 Latest commit e75061d
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/65462cef013d0200080d2151

@Routhleck
Copy link
Contributor Author

@jim19930609

@jim19930609 jim19930609 changed the title [cmake] Fix missing .so in manylinux2014 environment [aot] Fix missing .so in manylinux2014 environment Nov 6, 2023
@jim19930609 jim19930609 merged commit 5edb20b into taichi-dev:master Nov 6, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants