[bug] Fix crashing when a SNode is destroyed after taichi resets #8393
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for docsite-preview ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
jim19930609
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: fixes #8381
Brief Summary
🤖 Generated by Copilot at bf37155
Improve memory management and stability for multiple programs by adding a
progattribute and a validity check toSNodeTree.Walkthrough
🤖 Generated by Copilot at bf37155
progattribute toSNodeTreeclass to store theProgramobject that created the tree (link)SNodeTreefrom being destroyed by a different or invalid program by checking theprogattribute in thedestroymethod (link)