Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[aot] Support multiple AOT runtime devices #8275

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

PENGUINLIONG
Copy link
Member

@PENGUINLIONG PENGUINLIONG commented Jul 11, 2023

Issue: #

Brief Summary

🤖 Generated by Copilot at 34529d5

Add Vulkan device selection and error handling to C-API. This allows users to specify a device_index for the Vulkan backend in taichi_core_impl.cpp, and raises an exception for invalid indices for other backends.

Walkthrough

🤖 Generated by Copilot at 34529d5

  • Enable selecting a Vulkan device with the C-API by removing the zero check and calling set_vulkan_device_index with the device_index parameter (link)
  • Add zero checks and error messages for the other backends that do not support selecting a device with the C-API: CUDA (link), Metal (link), OpenGL (link), CC (link), and LLVM (link)

@netlify
Copy link

netlify bot commented Jul 11, 2023

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit 8c9db28
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/64ae0fdf7cd1b60008421574
😎 Deploy Preview https://deploy-preview-8275--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@PENGUINLIONG PENGUINLIONG requested a review from ailzhang July 12, 2023 03:24
Copy link
Contributor

@ailzhang ailzhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ailzhang ailzhang merged commit 6b563a2 into taichi-dev:master Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants