Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[lang] Build sparse matrix using ndarray #6563

Merged
merged 10 commits into from
Nov 14, 2022

Conversation

FantasyVR
Copy link
Collaborator

Issue: #2906

Brief Summary

Replace the array storing triplets in sparse matrix builder with ndarray. It unifies the sparse matrix builder creation on the CPU and GPU.

@netlify
Copy link

netlify bot commented Nov 10, 2022

Deploy Preview for docsite-preview ready!

Name Link
🔨 Latest commit b6f938f
🔍 Latest deploy log https://app.netlify.com/sites/docsite-preview/deploys/636e51c3cc732800092ccc79
😎 Deploy Preview https://deploy-preview-6563--docsite-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tests/python/test_sparse_matrix.py Outdated Show resolved Hide resolved
misc/sparse_matrix.py Outdated Show resolved Hide resolved
tests/python/test_sparse_linear_solver.py Outdated Show resolved Hide resolved
taichi/program/sparse_matrix.cpp Outdated Show resolved Hide resolved
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

Copy link
Collaborator Author

@FantasyVR FantasyVR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The triplets on GPU cannot be directly used to build a sparse matrix. It should be sorted first and then separated into three arrays. This would be implemented in another PR.

@FantasyVR FantasyVR merged commit a74d3f6 into taichi-dev:master Nov 14, 2022
strongoier added a commit that referenced this pull request Nov 14, 2022
ailzhang pushed a commit that referenced this pull request Nov 14, 2022
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Issue: taichi-dev#2906 

### Brief Summary
Replace the array storing triplets in sparse matrix builder with
ndarray. It unifies the sparse matrix builder creation on the CPU and
GPU.

Co-authored-by: Yi Xu <[email protected]>
quadpixels pushed a commit to quadpixels/taichi that referenced this pull request May 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants