Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lang] Use ti.linalg.SparseMatrixBuilder as sparse matrix builder #3152

Merged
merged 2 commits into from
Oct 11, 2021
Merged

[Lang] Use ti.linalg.SparseMatrixBuilder as sparse matrix builder #3152

merged 2 commits into from
Oct 11, 2021

Conversation

FantasyVR
Copy link
Collaborator

Related issue = #2906

@netlify
Copy link

netlify bot commented Oct 11, 2021 •
edited
Loading

✔️ Deploy Preview for jovial-fermat-aa59dc canceled.

🔨 Explore the source changes: f552f42

🔍 Inspect the deploy log: https://app.netlify.com/sites/jovial-fermat-aa59dc/deploys/6163fac9d68b56000831248b

@FantasyVR FantasyVR requested review from k-ye and Hanke98 October 11, 2021 08:53
Hanke98
Hanke98 approved these changes Oct 11, 2021
View reviewed changes
Copy link
Contributor

@Hanke98 Hanke98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!
BTW, do we need to change the ti.SparseSolver to ti.linalg.SparseSolver too?

python/taichi/lang/__init__.py Show resolved Hide resolved
@k-ye k-ye merged commit 9ef9c74 into taichi-dev:master Oct 11, 2021
@FantasyVR FantasyVR deleted the linalgSparseMatrix branch October 11, 2021 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hanke98 Hanke98 Hanke98 approved these changes

@k-ye k-ye Awaiting requested review from k-ye

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FantasyVR @k-ye @Hanke98