Allanx2000 #1
Allanx2000 #1
Conversation
-Add to Main to test
-Implement it as a custom control instead of view and controller
Codecov Report
@@ Coverage Diff @@
## develop #1 +/- ##
============================================
- Coverage 12.5% 7.19% -5.31%
Complexity 4 4
============================================
Files 5 7 +2
Lines 72 139 +67
Branches 0 3 +3
============================================
+ Hits 9 10 +1
- Misses 63 129 +66
Continue to review full report at Codecov.
|
-Add test usage to Main
src/main/java/Main.java
Outdated
| @@ -26,6 +40,26 @@ public void start(Stage primaryStage) throws Exception{ | |||
| tt.setAutoReverse(true); | |||
| tt.setCycleCount(99); | |||
| //tt.play(); | |||
|
|
|||
| api.getRants(Sort.ALGO, 10, 0).thenAcceptAsync(results -> { | |||
There was a problem hiding this comment.
This is not the place to get the rants. In a controller maybe? Also, you should use thenAccept()
There was a problem hiding this comment.
Ah OK for supply and then accept confused, thought then accept her to be async as well.
This was just for testing the PostControl and highlight the issue I'm having with the image
| /** | ||
| * Created by Tahnik Mustasin on 19/02/2017. | ||
| */ | ||
| public class PostControl extends BorderPane{ |
There was a problem hiding this comment.
This class looks like a model, not a controller. Also, why is extending borderpane? You should use an FXML instead and modify that via controllers.
There was a problem hiding this comment.
https://docs.oracle.com/javase/8/javafx/fxml-tutorial/custom_control.htm
I followed this to make it a reuseable control
Start prototyping the post control and needed assets