Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing hang in alpine linux and adding test #147

Merged
merged 1 commit into from
Feb 26, 2020

Conversation

ryhinchey
Copy link
Collaborator

This PR fixes issue #81. The work was mostly done here but got reverted at some point. I also added a test for ash.

I tested this in an alpine linux docker container locally as well.

@ryhinchey ryhinchey requested a review from tabrindle February 24, 2020 15:42
@ryhinchey
Copy link
Collaborator Author

The Travis build is failing with the message error Your lockfile needs to be updated, but yarn was run with --frozen-lockfile. I didn't change any dependencies but when I run yarn locally, I see this addition to yarn.lock:

prettier@^1.19.1:
  version "1.19.1"
  resolved "https://registry.yarnpkg.com/prettier/-/prettier-1.19.1.tgz#f7d7f5ff8a9cd872a7be4ca142095956a60797cb"
  integrity sha512-s7PoyDv/II1ObgQunCbB9PdLmUcBZcnWOcxDh7O0N/UwDEsHyqkW+Qh28jW+mVuCdx7gLB0BotYI1Y6uI9iyew==

Happy to commit - just let me know.

@tabrindle
Copy link
Owner

Sure, go ahead and fix that. Everything else looks good, thanks!

@tabrindle tabrindle merged commit cc2f270 into tabrindle:master Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants