Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

confgen: control field name presence at field-level and sheet-level #121

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

wenchy
Copy link
Member

@wenchy wenchy commented Aug 5, 2024

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 95.23810% with 2 lines in your changes missing coverage. Please review.

Project coverage is 66.96%. Comparing base (d2d37c7) to head (f938857).

Files Patch % Lines
internal/confgen/parser.go 89.47% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #121      +/-   ##
==========================================
+ Coverage   66.77%   66.96%   +0.19%     
==========================================
  Files          44       44              
  Lines        5532     5552      +20     
==========================================
+ Hits         3694     3718      +24     
+ Misses       1357     1355       -2     
+ Partials      481      479       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wenchy wenchy marked this pull request as ready for review August 6, 2024 06:19
Copy link
Collaborator

@Kybxd Kybxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Kybxd Kybxd merged commit e116e35 into master Aug 6, 2024
8 checks passed
@Kybxd Kybxd deleted the field-name-presence branch August 6, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants