Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: use generics to get messagers #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

YoungerLee
Copy link
Contributor

  • use generics function to get messagers rather than generate all getter functions
  • upgrade go version to 1.18

@wenchy wenchy added the help wanted Extra attention is needed label Apr 11, 2023
@wenchy
Copy link
Member

wenchy commented Apr 11, 2023

Generics may be not friendly to code auto-completion.

@wenchy
Copy link
Member

wenchy commented Apr 19, 2023

Problem: type parameters in methods

According to the Type parameters proposal, it is not allowed to define type parameters in methods.

Something like this:

type Store struct {}

func (s *Store) Get[model any](key string) (*model, error) {
  ...
}

Currently, having a generic inside a struct function can throw a syntax error like:

syntax error: method must have no type parameters

References

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants