-
Notifications
You must be signed in to change notification settings - Fork 159
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Fix bug cannot click on off-canvas menu item
Fix #359
- Loading branch information
Showing
2 changed files
with
9 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, there should be something like this:
if ($('html').hasClass("touch")) return;
Because there are larger touch devices, where grid breakpoint doesn't collapse menu or show off-canvas. And problem with lagging in megamenu submenus don't disappear. That line solve this problem, but I don't know if it is best solution.
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi Mino182,
where did you insert
if ($('html').hasClass("touch")) return;
?
My problem is not Off Canvas but the lagging submenus in megamenu on touch displays, for example android tablets or Windows 10 desktops with touch screens.
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, into line 394.
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you. This works on my windows 10 convertible only in chrome by touch. In Firefox it's even not possible to get the main menu item link via touch... I am talking about the T3 Menu which is shown on larger screens - not the off-canvas.
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok on Android it works even in Firefox. Maybe a convertible notebook is something special ;-) Thank you again.
3c809ee
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanx it worked ... but I have anchor links on the page - One Page Website, kind of - which are scrolling down to content and are again scrolling up automatically. What to do for it.