Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker - Client and common compose #20

Merged
merged 20 commits into from
Jul 9, 2022
Merged

Docker - Client and common compose #20

merged 20 commits into from
Jul 9, 2022

Conversation

djavorek
Copy link
Collaborator

@djavorek djavorek commented Jun 17, 2022

Description of Changes

  • Added Dockerfile for client

    • Multi-stage build
    • using node:18-alpine (node 18.4.0)
    • We are building with adapter-node from now, to be able to run SvelteKit as a node app (see: package.json, svelte.config.js)
  • Pulled up docker-compose into root, added client, and fixed context for server

  • Added dockerignore for both client and server to decrease image size.

  • Added new workflow, which builds 1-1 docker image for server and client, then publishes them into AWS ECR. (images.yml)

    • Docker build takes a while, eating our CI credits like crazy
      • Build waits pain-point builds to succeed before starts. (Updated the name of those jobs to be more clear)
      • Only runs on master commits.
  • Renovated README.md, added DEV.md for technical stuff.

    • Shiny new badge into README showing status of the new workflow
  • Using Vite directly for building and packaging (see: npm scripts, vite.config.js, svelte.config.js)

@djavorek djavorek marked this pull request as ready for review July 6, 2022 20:12
@djavorek djavorek requested a review from szattila98 July 7, 2022 19:56
szattila98
szattila98 previously approved these changes Jul 7, 2022
Copy link
Owner

@szattila98 szattila98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the little nitpick node version, very nice work in troubling times, thank you!

Skipping workflows not related to the PR
omit=dev in client dockerfile
@szattila98 szattila98 self-requested a review July 9, 2022 15:36
@djavorek djavorek merged commit 8df67da into main Jul 9, 2022
@djavorek djavorek deleted the docker_svelte branch July 9, 2022 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants