-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docker - Client and common compose #20
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No audit during build
szattila98
previously approved these changes
Jul 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the little nitpick node version, very nice work in troubling times, thank you!
szattila98
reviewed
Jul 7, 2022
Skipping workflows not related to the PR
omit=dev in client dockerfile
szattila98
approved these changes
Jul 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
Added Dockerfile for client
Pulled up docker-compose into root, added client, and fixed context for server
Added dockerignore for both client and server to decrease image size.
Added new workflow, which builds 1-1 docker image for server and client, then publishes them into AWS ECR. (images.yml)
Renovated README.md, added DEV.md for technical stuff.
Using Vite directly for building and packaging (see: npm scripts, vite.config.js, svelte.config.js)
@sveltejs/kit/experimental/vite
out of experimental sveltejs/kit#5184