Use given role_id on registration
#95
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
August 1, 2024 14:51
Extension template is installed. No github action for phpcs and phpstan, yet, because of too much errors. They need to be fixed first. Maybe the phpstan level could be (initially) reduced.
In `RegistrationEventFactory` the given `role_id` is used, even though it's not part of the profile fields. This restores previous behavior.
|
I'm not sure either. If role IDs are supposed to be submitted data from the profile form, they should be validated. I guess they were only supposed to be defined by the profile. Maybe @bjendres can remember …? |
dontub
force-pushed
the
run-tests-in-github-action
branch
from
f98ae7a to
fecf861
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
RegistrationEventFactorythe givenrole_idis used, even though it's not part of the profile fields. This restores previous behavior.There's no validation, as before. (The same holds true for
RemoteParticipant.update.) Actually I'm not sure if this is correct.