Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register event subscribers as services #60

Merged
merged 1 commit into from
Mar 15, 2024

Conversation

dontub
Copy link
Contributor

@dontub dontub commented Mar 15, 2024

Previously some subscribers where initialized and added to the event dispatcher in hook_civicrm_config().

CRM_Civioffice_Tokens is marked as lazy so this fixes #59.

Previously some subscribers where initialized and added to the event
dispatcher in `hook_civicrm_config()`.

`CRM_Civioffice_Tokens` is marked as lazy so this fixes #59.
@dontub dontub requested a review from jensschuppe March 15, 2024 10:14
Copy link
Contributor

@jensschuppe jensschuppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving code-wise, haven't tested.

@dontub dontub merged commit 77c9b8c into master Mar 15, 2024
10 checks passed
@dontub dontub deleted the register-event-subscribers-as-services branch March 15, 2024 16:44
@jensschuppe jensschuppe added bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code) labels Mar 18, 2024
@jensschuppe jensschuppe added this to the 1.0 milestone Mar 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working status:fixed The issue has been resolved (usually by committing/merging code)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Live snippets should not be loaded in config hook
2 participants