Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Install/setup fixes #48

Closed
wants to merge 2 commits into from
Closed

Install/setup fixes #48

wants to merge 2 commits into from

Conversation

mattwire
Copy link
Contributor

@mattwire mattwire commented Nov 8, 2023 •
edited
Loading

If webserver has open_basedir restriction in effect you can't test for executable in system path. It gets checked later in isReady() anyway

On PHP8.1 a missing lock file causes flock to crash with a type error. Then you can't load the initial configuration page.

@mattwire mattwire changed the title Fixes Install fixes Nov 8, 2023
@mattwire mattwire changed the title Install fixes Install/setup fixes Nov 8, 2023
@jensschuppe
Copy link
Contributor

@mattwire we just merged #49 which, while checking for it, tries to create the lock file when it doesn't exist. I think parts of your PR would still be needed for the scenario you described - could you try to rebase your PR on the current master?

@jensschuppe jensschuppe added this to the 1.0 milestone Mar 11, 2024
@jensschuppe jensschuppe added bug Something isn't working status:needs work There is code, but it needs additional work before it should be reviewed labels Mar 11, 2024
mattwire added 2 commits March 19, 2024 23:50
@mattwire
If webserver has open_basedir restriction in effect you can't test fo…
d026a84 
…r executable in system path. It gets checked later in isReady() anyway
@mattwire
On PHP8.1 a missing lock file causes flock to crash with a type error…
e1410da 
…. Then you can't load the initial configuration page..
@mattwire
Copy link
Contributor Author

@jensschuppe I rebased on top of your changes

@jensschuppe jensschuppe requested a review from dontub March 21, 2024 13:47
@jensschuppe jensschuppe added status:needs review Code needs review and testing and removed status:needs work There is code, but it needs additional work before it should be reviewed labels Mar 21, 2024
@jensschuppe jensschuppe mentioned this pull request Apr 9, 2024
Closed
@mattwire
Copy link
Contributor Author

Closing. Will re-open if an issue when I next install

@mattwire mattwire closed this Jul 22, 2024
@mattwire mattwire deleted the fixes branch October 6, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dontub dontub Awaiting requested review from dontub

Assignees
No one assigned
Labels
bug Something isn't working status:needs review Code needs review and testing
Projects
None yet
Milestone
1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@mattwire @jensschuppe